# Season ↔ Tournament Drift Audit **Date:** July 17, 2026 **Method:** Parallel review of every player-facing "twin" — code copied from the season flow to create the tournament flow (or vice versa) — hunting fixes that landed on one side only. Five review passes: cancellation forms, GroupController branches, RegistrationController branches, OrderCompleteSubscriber branches, notifications + admin GroupInvitationsForm. Key findings spot-verified against source. **Companions:** `INVITATION_FLOW_ANALYSIS.md`, `ORDER_FLOW_EDGE_CASES.md` (findings there are not repeated). > **STATUS as of July 28, 2026 — see `OUTSTANDING_ISSUES.md` for the live list.** > **Shipped to PROD:** D1 (100× refund money bug), D8 (`removeMember` cleanup on both branches). > **Fixed, awaiting deploy:** D4 (co-captain remove) + T9 — in `fix/team_display`, untested; D14 (tournament > nudge 500) — in `fix/tournament_nudge_500`, on TEST, not PROD. > **Still open and relevant to the roster/schedule/tournament work:** D2 (admin-accept of a tournament > invitation crashes mid-transaction), D3 (tournament completion doesn't re-check active/visible), D6/D7 > (tournament cancel + admin accept/decline desync `Team.players` → ghost roster members), D13 (season group > counts include cancelled regs — P1 roster hygiene), D5 (tournament cancel notifies nobody), D12 (tournament > close date has no fallback), D17 (no tournament `groups_locked` — board decision if rosters need freezing). > **Lower/parked:** D9–D11, D15, D16, D18, D20. > > **UPDATE July 30, 2026 — D19 promoted from ⚪ Low to 🟠 High and moved.** The conditional it was parked > under ("flag in case shared UI ever counts on it") has fired: the admin Group Invitations page counts on > it in two places that now contradict each other on screen, and its **Save** button writes the wrong value > as real data. Fix is scoped as **CF12** in `ROSTER_RECONCILIATION_PLAN.md` §5/§10.3, shipping with CF2+D2 > in commit 2. Half of **D15** is retired by the same change. Branch/deploy states above are as of July 28 > and are superseded by `SESSION_HANDOFF.md` (July 29) — `fix/team_display` has since merged to main. --- ## 🔴 Critical ### D1 — Season Commerce refund is off by 100x (money bug) — VERIFIED `CancelRegistrationForm.php:526-527`: ```php $amount_cents = (string) ($amount_dollars * 100); $refund_amount = new Price($amount_cents, ...); ``` `commerce_price\Price` takes **dollars**, not cents — the tournament twin does it right (`TournamentCancelRegistrationForm.php:376`, no `*100`), as does `TournamentDepositRefundForm.php:220`. Practical behavior: refunds larger than 1/100 of the captured payment throw/decline (refund > capture), so **the season "Refund via Commerce" option is effectively broken** — and the dangerous case is a small partial refund: refund $0.50 on a $50 order → succeeds as a **$50 refund**. Do not use the season Commerce-refund option until fixed (credit option is unaffected). One-line fix; tournament side is the template. **Confirmed in production July 17:** order 87 (Avi, $133, cancelled Jul 8) — payment shows "Refunded: $0.00", state Completed, no credits issued. The refund silently failed via this exact path; player was never notified. Remediated manually via the order's Payments tab (Commerce core refund). **✅ IMPLEMENTED July 17, 2026** (uncommitted working-tree change, `CancelRegistrationForm.php`): dropped the `* 100` (Price takes dollars, matching the tournament forms); validation now rejects `$0` refunds; the refund-failure message now states explicitly that no money moved and the player was not notified, with manual-remediation instructions. Deploy: code only, `drush cr`. Test on LOCAL/TEST with a test-gateway order: commerce refund of a normal amount succeeds and payment state flips to Refunded; refund > captured amount shows the failure message. ### D2 — Admin-accepting a tournament invitation crashes mid-transaction — VERIFIED `GroupInvitationsForm.php:1279` queries `loadByProperties(['tournament' => $context_id, ...])`, but the Invitation entity **has no `tournament` field** (only `season`, `group_id`, `team` — `Invitation.php:83-112`). Entity query on an undefined field throws. The call happens *after* the registration was already mutated and saved (`acceptInvitation()` → line ~1238), so the admin gets an error page with half-committed state: player joined the team, invitation left `pending`, competing invites never declined. Correct pattern exists in `GroupController::acceptTeamInvitation()` (filter by `isTeamInvite()` + team's tournament). Season branch uses the real `season` field and works. ### D3 — Tournament order completion never re-checks that the tournament is still open Season completion hard-blocks and flags the order if the season went inactive/hidden mid-checkout (`OrderCompleteSubscriber.php:364`, Finding F). The tournament branch has **no check of `active`, `registration_visible`, or `status`** — a player checking out while an admin cancels the tournament still gets a `paid` registration, and the `create` branch still spawns a Team entity + team-name taxonomy term for a dead tournament. Money captured, no flag, no admin surface. Port the season guard (+ flag write) to `createTournamentRegistration()`. --- ## 🟠 High ### ~~D4 — Co-captains can see manager controls but every remove fails~~ ✅ IMPLEMENTED July 27, 2026 `manage()` treats captain OR co-captain as manager (`isTeamLeader()`, GroupController:404) and renders Remove buttons — but `removeMember()` gates on the season rule only (`invited_by` empty, line 1465). A co-captain always has `invited_by` set → **"Only the group manager can remove members"** on every click. Meanwhile co-captain *invite* works. Fix: tournament branch of `removeMember()` should use `isTeamLeader()`. **Fixed as prescribed.** `removeMember()` now resolves `$is_tournament`/`$team` before the authorization check and branches: tournaments authorize via `$team->isTeamLeader()`, seasons keep the `invited_by` rule. Two things had to come with it: - **Captain protection (new, required by this fix).** Nothing stopped a co-captain from removing the *captain* — it had never mattered, because no co-captain could get past the auth check. `removeMember()` splices `Team.players` inline and never calls `TournamentTeamManager::removePlayerFromTeam()`, where the equivalent guard already lives. Added an explicit guard; the captain must be transferred first. - **T9 co-captain cleanup.** Removing a co-captain now clears `Team.co_captain`, which otherwise kept pointing at someone off the roster — and `isTeamLeader()` would have kept granting them rights over a team they had left. Also fixed in the same pass, both surfaced by a live report (Yong Pong, Lunch Crew, SLO Friendly 2026): - **Membership check was group_id-based.** A tournament player placed as a free agent by the Roster Builder has `group_id` NULL by design, so the captain got "Member is not in your group" for someone visibly on the roster. Now accepts either source of truth — `Registration.team` match **or** presence in `Team.players` — because the two are known to drift (T2/T5/D7) and the on-screen roster renders from `Team.players`. A strict check would have refused to remove rows the page itself drew. - **Missing status filter on the roster's registration lookup** (`manage()`, tournament branch). It fed the Remove button's member id via `reset()`, which takes the lowest id — so a player with a cancelled *and* a live registration had the cancelled row wired to the button. **6th confirmed instance** of this shape. Extracted as `pickLiveRegistration()`. ### D5 — Tournament cancellation notifies nobody Season cancel emails the player in all three refund branches (`sendRegistrationCancelled`, CancelRegistrationForm:392-435). Tournament cancel (`TournamentCancelRegistrationForm.php:238-327`) sets status, processes the refund, messages the **admin's screen only** — the player is silently dropped (and possibly silently refunded). Also cross-check with ORDER_FLOW S1: even the season email is preference-gated. ### D6 — Tournament cancel leaves the player on the team roster Neither cancel form removes the player from `Team.players` or clears `group_id`/`invited_by` — but the module already has the correct helper doing exactly this: `TournamentTeamManager::unassignPlayerFromTeam()` (TournamentTeamManager.php:470-503). The cancel form just doesn't call it. Ghost roster entries inflate `isFull()` and block real joins. (Season half of this is INVITATION doc E4.) ### D19 — `invitation_status` is never written on tournament registrations, and the admin page renders the gap as "Pending" — VERIFIED *(Promoted from ⚪ Low July 30, 2026. Original entry: "model difference, flag in case shared UI ever counts on it." It does.)* `createTournamentRegistration()` (`OrderCompleteSubscriber.php` ~850-864) builds the registration with `team`, `group_id` and `invited_by` but **no `invitation_status`** — the season branch 300 lines earlier passes it explicitly (`:559`). So every tournament registration stores the field default `'none'` (`Registration.php:166-168`). `'none'` is not among `GroupInvitationsForm::buildMembersTable()`'s three select options (`:548`). A `